From 7a085385166ecf1d4aae8ed91e677e47a501cbf4 Mon Sep 17 00:00:00 2001
From: Dominique Marcadet <Dominique Marcadet@centralesupelec.fr>
Date: Tue, 30 Apr 2019 16:49:28 +0800
Subject: [PATCH] signal not implemented validation

---
 .../iec61850/scl/validator/AnyLNValidator.java    | 15 +++++++++++----
 .../iec61850/scl/validator/DOIValidator.java      |  8 ++++++++
 .../scl/validator/NsdEObjectValidator.java        |  2 +-
 3 files changed, 20 insertions(+), 5 deletions(-)

diff --git a/fr.centralesupelec.edf.riseclipse.iec61850.scl.tools/src/fr/centralesupelec/edf/riseclipse/iec61850/scl/validator/AnyLNValidator.java b/fr.centralesupelec.edf.riseclipse.iec61850.scl.tools/src/fr/centralesupelec/edf/riseclipse/iec61850/scl/validator/AnyLNValidator.java
index 52e9054..fca7c7e 100644
--- a/fr.centralesupelec.edf.riseclipse.iec61850.scl.tools/src/fr/centralesupelec/edf/riseclipse/iec61850/scl/validator/AnyLNValidator.java
+++ b/fr.centralesupelec.edf.riseclipse.iec61850.scl.tools/src/fr/centralesupelec/edf/riseclipse/iec61850/scl/validator/AnyLNValidator.java
@@ -55,7 +55,7 @@ public class AnyLNValidator {
 
     }
 
-    public void generateValidators( HashMap< String, DataObject > doMap, HashMap< String, DOIValidator > cdcMap, AnyLNClass lnClass ) {
+    private void generateValidators( HashMap< String, DataObject > doMap, HashMap< String, DOIValidator > cdcMap, AnyLNClass lnClass ) {
         for( DataObject dObj : lnClass.getDataObject() ) {
             doMap.put( dObj.getName(), dObj );
             if( dObj.getRefersToCDC() != null ) {
@@ -110,7 +110,7 @@ public class AnyLNValidator {
         return res;
     }
 
-    public boolean checkCompulsory( AnyLN ln, DataObject dataObject, HashSet< String > checkedDO, DiagnosticChain diagnostics ) {
+    private boolean checkCompulsory( AnyLN ln, DataObject dataObject, HashSet< String > checkedDO, DiagnosticChain diagnostics ) {
         switch( dataObject.getPresCond() ) {
         case "M":
             if( ! checkedDO.contains( dataObject.getName() ) ) {
@@ -122,11 +122,15 @@ public class AnyLNValidator {
                         new Object[] { ln } ));
                 return false;
             }
+            break;
+        default:
+            AbstractRiseClipseConsole.getConsole().info( "NOT IMPLEMENTED: AnyLNValidator.checkCompulsory( " + dataObject.getPresCond() + " )" );
+            break;
         }
         return true;
     }
 
-    public boolean updateCompulsory( DOI doi, HashSet< String > checkedDO, DiagnosticChain diagnostics ) {
+    private boolean updateCompulsory( DOI doi, HashSet< String > checkedDO, DiagnosticChain diagnostics ) {
         switch( doMap.get( doi.getName() ).getPresCond() ) {
         case "M":
         case "O":
@@ -149,11 +153,14 @@ public class AnyLNValidator {
                     "DO " + doi + " is forbidden in LN at line " + doi.getParentAnyLN().getLineNumber(),
                     new Object[] { doi } ));
             return false;
+        default:
+            AbstractRiseClipseConsole.getConsole().info( "NOT IMPLEMENTED: AnyLNValidator.updateCompulsory( " + doMap.get( doi.getName() ).getPresCond() + " )" );
+            break;
         }
         return true;
     }
 
-    public boolean validateDOI( DOI doi, DiagnosticChain diagnostics ) {
+    private boolean validateDOI( DOI doi, DiagnosticChain diagnostics ) {
 
         AbstractRiseClipseConsole.getConsole().verbose( "found DO " + doi.getName() + " in LNClass " + lnClass );
 
diff --git a/fr.centralesupelec.edf.riseclipse.iec61850.scl.tools/src/fr/centralesupelec/edf/riseclipse/iec61850/scl/validator/DOIValidator.java b/fr.centralesupelec.edf.riseclipse.iec61850.scl.tools/src/fr/centralesupelec/edf/riseclipse/iec61850/scl/validator/DOIValidator.java
index 7f0d306..a75df40 100644
--- a/fr.centralesupelec.edf.riseclipse.iec61850.scl.tools/src/fr/centralesupelec/edf/riseclipse/iec61850/scl/validator/DOIValidator.java
+++ b/fr.centralesupelec.edf.riseclipse.iec61850.scl.tools/src/fr/centralesupelec/edf/riseclipse/iec61850/scl/validator/DOIValidator.java
@@ -102,6 +102,10 @@ public class DOIValidator {
                         new Object[] { da } ));
                 return false;
             }
+            break;
+        default:
+            AbstractRiseClipseConsole.getConsole().info( "NOT IMPLEMENTED: DOIValidator.checkCompulsory( " + da.getPresCond() + " )" );
+            break;
         }
         return true;
     }
@@ -131,6 +135,9 @@ public class DOIValidator {
                     "DAI " + dai.getName() + " (line " + dai.getLineNumber() + ") is forbidden",
                     new Object[] { dai } ));
             return false;
+        default:
+            AbstractRiseClipseConsole.getConsole().info( "NOT IMPLEMENTED: DOIValidator.updateCompulsory( " + daMap.get( dai.getName() ).getPresCond() + " )" );
+            break;
         }
         return true;
     }
@@ -247,6 +254,7 @@ public class DOIValidator {
         }
     }
 
+    @SuppressWarnings( "unused" )
     private void testValidateVal() {
         log( "\n--\tSTART TEST\t--\n" );
         assertTrue( validateVal( "0", "BOOLEAN" ) );
diff --git a/fr.centralesupelec.edf.riseclipse.iec61850.scl.tools/src/fr/centralesupelec/edf/riseclipse/iec61850/scl/validator/NsdEObjectValidator.java b/fr.centralesupelec.edf.riseclipse.iec61850.scl.tools/src/fr/centralesupelec/edf/riseclipse/iec61850/scl/validator/NsdEObjectValidator.java
index fa2ef5e..fd57da4 100644
--- a/fr.centralesupelec.edf.riseclipse.iec61850.scl.tools/src/fr/centralesupelec/edf/riseclipse/iec61850/scl/validator/NsdEObjectValidator.java
+++ b/fr.centralesupelec.edf.riseclipse.iec61850.scl.tools/src/fr/centralesupelec/edf/riseclipse/iec61850/scl/validator/NsdEObjectValidator.java
@@ -89,7 +89,7 @@ public class NsdEObjectValidator implements EValidator {
         return true;
     }
 
-    public boolean validateLN( AnyLN ln, DiagnosticChain diagnostics ) {
+    private boolean validateLN( AnyLN ln, DiagnosticChain diagnostics ) {
         AbstractRiseClipseConsole.getConsole().verbose( "" );
         AbstractRiseClipseConsole.getConsole().verbose( "NsdEObjectValidator.validateLN( " + ln.getLnClass() + " )" );
 
-- 
GitLab